Skip to content

Dynamic fuel switching #121 - #154

Merged
t-kramer merged 5 commits into
developmentfrom
fuel-switching-#121
Sep 4, 2026
Merged

Dynamic fuel switching #121#154
t-kramer merged 5 commits into
developmentfrom
fuel-switching-#121

Conversation

@urwahah

@urwahah urwahah commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

For #121:

  • Added a new fuel switching input "Use optimal heating fuel" under the backup heating equipment selection
  • Added new scenarios and scenario group to compare fuel switching
  • Added new columns to the loads_to_site dataframe:
    • FUEL_SWITCHING, HHW_REM_W_NG_MODE, BOILER_HHW_W_NG_MODE, GAS_BOILER_WH_NG_MODE, intermediate columns to store the "natural gas mode" load/energy use that it reverts to if gas emissions < electric emissions
    • BOILER_EQ_CALC, BOILER_CAP_W to store the scenario's boiler sizing information as it's used in the emissions function
  • Added fuel switching calculation in site_to_source
  • Moved the boiler sizing calculation to site_to_source

Here is a link to the change request to update docs for this.

A few minor changes unrelated to the fuel switching:

  • Updated the AWHP sizing logic to use the remaining HHW/CHW loads instead of the original load profile. For heat recovery scenarios this will allow the AWHP to be downsized. (This is the change causing the merge conflicts, I think all the new changes should be accepted but wasn't sure if me doing that would also merge the PR)
  • Added a 60% efficiency boiler

@urwahah urwahah added this to the 02 | Capability expansion milestone Aug 18, 2026
Comment thread src/energy.py
@urwahah
urwahah requested a review from t-kramer August 18, 2026 01:36

@t-kramer t-kramer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @urwahah, great work as always.

I added some minor comments/questions that should be pretty easy handle. Let me know if you have questions. When these are resolved, I'll go ahead with the merge and handle the merge conflicts.

Comment thread src/equipment.py Outdated
Comment thread pages/equipment_page.py Outdated
Comment thread src/energy.py
Comment thread src/energy.py
Comment thread src/energy.py
Comment thread src/energy.py
Comment thread data/input/equipment_data.JSON
Comment thread data/input/equipment_data.JSON Outdated
Comment thread src/energy.py Outdated
@urwahah

urwahah commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

@t-kramer - updated based on your review, i left open a few comments with responses.
@praftery - could you take a look at the new scenario group before we merge? looking back on it i'm not 100% sure i have reasonable ones based on what we discussed a few weeks ago.

@t-kramer
t-kramer merged commit 47b81c3 into development Sep 4, 2026
@t-kramer
t-kramer deleted the fuel-switching-#121 branch September 4, 2026 23:39
@t-kramer

t-kramer commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

@urwahah The branch is merged into development. If you want to make adjustments after hearing from @praftery, please submit a new PR with the changes.

Also, please double check the updates to development. I had to make some minor fixes after one callback threw a bunch of errors after merging #154. Can you check if everything works as expected? 🙏

@urwahah

urwahah commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator Author

got it, thank you! just checked and looks like everything's working fine to me @t-kramer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants